[PATCH: Offline Backup 2]

[Andrew Bartlett]

G'Day Aaron.

I know this has been a saga, but you have toiled mightily and
succeeded.

I'm happy with this patch, and very glad to see a safe local backup
tool arrive, and the previous unlocked tool removed.

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Can I get a second team reviewer please?

Thanks,

Andrew Bartlett

On Wed, 2018-08-01 at 16:51 +1200, Aaron Haslett via samba-technical
wrote:
> Patch attached and here's the CI run:
> 
> https://gitlab.com/catalyst-samba/samba/pipelines/26925397
> 
> 
> On 01/08/18 16:46, Aaron Haslett wrote:
> > Here's a new version of the patch.  This version contains several bug
> > fixes, stylistic fixes, more detailed commenting, and moves the
> > tdbbackup test into lib/tdb so it can be run as part of tdb standalone.
> > 
> > 
> > On 25/07/18 16:50, Aaron Haslett wrote:
> > > The samba_backup bash script is a tool that creates a local backup of a
> > > DC using the file system.  This patch replaces that script with a new
> > > samba-tool command called "domain backup offline".
> > > 
> > > If the samba_backup bash script is used on a DC while it is running,
> > > there could be database corruption.  This patch adds readonly locking
> > > mode to the tdbbackup tool and uses the new functionality to do a safe
> > > backup.  Thorough testing is added, including a new testenv target
> > > constructed from a backup created by the new tool.  The new target is
> > > tagged against all the same tests as the existing 'backup online' and
> > > 'rename' targets.
> > > 
> 
> 
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba