[PATCH] Allow editing groups from samba-tool
william at blackhats.net.au
Mon Apr 30 23:05:50 UTC 2018
On Mon, 2018-04-30 at 08:32 +0300, Alexander Bokovoy via samba-
> On ma, 30 huhti 2018, William Brown via samba-technical wrote:
> > Hi there,
> > samba tool allows a command like "user edit" that opens the object
> > as
> > an ldif, and it can be edited and commited.
> > This modifies the location of that implementation to be a generic
> > EditCommand that can be derived, and demonstrates how it could be
> > implemented for group also.
> > One minor detail is how we pass in the "type". Should this be a
> > "self.attribute" of the EditCommand rather than an argument to
> > run_edit? filter makes sense to be an argument due to unknown
> > string
> > formatting for the filter, similar with the samaccount name being
> > an
> > argument for error messages. But the type could be a self
> > attribute.
> I think passing filter is more flexible here.
> There is one comment I'd like to address but otherwise it looks good.
> See inline.
I have addressed your comment in this updated patch. Thanks for
spotting the issue!
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 14408 bytes
Desc: not available
More information about the samba-technical