[PATCH] Add missing async fsync_send()/recv() code to ceph VFS.

Jeremy Allison jra at samba.org
Mon Apr 30 21:46:25 UTC 2018

On Mon, Apr 30, 2018 at 07:03:01PM +0200, Ralph Böhme wrote:
> On Mon, Apr 30, 2018 at 09:30:41AM -0700, Jeremy Allison wrote:
> > On Mon, Apr 30, 2018 at 11:29:16AM +0200, Ralph Böhme wrote:
> > > 
> > > vfs_ceph doesn't implement profiling so it doesn't really matter, cf the
> > > SMBPROFILE_BYTES_ASYNC_* macros in vfs_default how it would look like.
> > > 
> > > So I guess you can either remove the PROFILE_TIMESTAMP macro invocations or
> > > implement the profiling stuff.
> > 
> > OK, here is version #2, including the changes you guys discussed.
> > 
> > Please review and push if happy. I have a follow-up patch that
> > removes all uses of the synchronous fsync_fn() from the VFS once
> > this one goes in :-).
> pushed.

Hurrah - it went in, thanks ! Now I have your attention,
here is the follow-up that removes the synchronous fsync_fn()
completely from the VFS.

Please review and let me know what you think !

FYI: I'm half way though doing the same for SMB_VFS_READ
(converting that to SMB_VFS_PREAD everywhere and then
pairs). Finally I'll get to SMB_VFS_WRITE and do the same,
and we should end up with only *one* way to do a VFS
FSYNC/READ/WRITE in the backend - and that will be asynchronous,
instead of the current two or three different ways, some
sync, some async.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fsync_remove.patch
Type: text/x-diff
Size: 15318 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180430/f925bf98/fsync_remove.diff>

More information about the samba-technical mailing list