[PATCH] Allow editing groups from samba-tool

William Brown william at blackhats.net.au
Mon Apr 30 02:34:26 UTC 2018

Hi there,

samba tool allows a command like "user edit" that opens the object as
an ldif, and it can be edited and commited.

This modifies the location of that implementation to be a generic
EditCommand that can be derived, and demonstrates how it could be
implemented for group also.

One minor detail is how we pass in the "type". Should this be a
"self.attribute" of the EditCommand rather than an argument to
run_edit? filter makes sense to be an argument due to unknown string
formatting for the filter, similar with the samaccount name being an
argument for error messages. But the type could be a self attribute.

Thanks for your review!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-python-samba-netcmd-__init__.py-user.py-group.py-imp.patch
Type: text/x-patch
Size: 13787 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180430/0dcc2a50/0001-python-samba-netcmd-__init__.py-user.py-group.py-imp.bin>

More information about the samba-technical mailing list