[PATCH] build: add option to choose to build with or without JSON audit support

Andrew Bartlett abartlet at samba.org
Sun Apr 29 18:53:36 UTC 2018


On Tue, 2018-04-17 at 15:59 +0200, Bj├Ârn Baumbach via samba-technical
wrote:
> Hi!
> 
> I've prepared an option to disable or enforce the build with support for
> JSON auth audit, which needs the jansson library.
> 
> By default the jansson library is auto-detected and is then used for the
> JSON auth audit method.
> 
> Review is appreciated!

I realise this is already in, but could we please have the default
being True?  It is correct that this is the no-change behaviour, but on
reflection we have made many other things bug the user to install
packages or explicitly disable the feature, and doing so would ensure
that more packages and more installs get to use this functionality.  

(Because folks doing the build are prompted).

Either way, the smb.conf manpage section also needs to be updated.

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list