[PATCH] Fix strict aliasing warnings in ctdb_client

[Andreas Schneider]

On Friday, 27 April 2018 16:47:10 CEST Andreas Schneider via samba-technical 
wrote:
> Hi,
> 
> see attached.
> 
> 
> Review much appreciated.

Well the function is unused an can be removed ...


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
>From 61a4d8721ea64b5a878608beba298261b4d167f6 Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn at samba.org>
Date: Fri, 27 Apr 2018 16:43:04 +0200
Subject: [PATCH] ctdb: Remove unused ctdb_ctrl_getdbseqnum()

This fixes strict aliasing warnings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13411

Signed-off-by: Andreas Schneider <asn at samba.org>
---
 ctdb/client/ctdb_client.c  | 36 ------------------------------------
 ctdb/include/ctdb_client.h |  2 --
 2 files changed, 38 deletions(-)

diff --git a/ctdb/client/ctdb_client.c b/ctdb/client/ctdb_client.c
index a7624b7e3c8..45a9a13737b 100644
--- a/ctdb/client/ctdb_client.c
+++ b/ctdb/client/ctdb_client.c
@@ -1870,42 +1870,6 @@ int ctdb_ctrl_getdbhealth(struct ctdb_context *ctdb,
 	return 0;
 }
 
-/*
- * get db sequence number
- */
-int ctdb_ctrl_getdbseqnum(struct ctdb_context *ctdb, struct timeval timeout,
-			  uint32_t destnode, uint32_t dbid, uint64_t *seqnum)
-{
-	int ret;
-	int32_t res;
-	TDB_DATA data, outdata;
-	uint8_t buf[sizeof(uint64_t)] = { 0 };
-
-	*(uint32_t *)buf = dbid;
-	data.dptr = buf;
-	data.dsize = sizeof(uint64_t);
-
-	ret = ctdb_control(ctdb, destnode, 0, CTDB_CONTROL_GET_DB_SEQNUM,
-			   0, data, ctdb, &outdata, &res, &timeout, NULL);
-	if (ret != 0 || res != 0) {
-		DEBUG(DEBUG_ERR,("ctdb_control for getdbesqnum failed\n"));
-		return -1;
-	}
-
-	if (outdata.dsize != sizeof(uint64_t)) {
-		DEBUG(DEBUG_ERR,("Invalid return data in get_dbseqnum\n"));
-		talloc_free(outdata.dptr);
-		return -1;
-	}
-
-	if (seqnum != NULL) {
-		*seqnum = *(uint64_t *)outdata.dptr;
-	}
-	talloc_free(outdata.dptr);
-
-	return 0;
-}
-
 /*
   create a database
  */
diff --git a/ctdb/include/ctdb_client.h b/ctdb/include/ctdb_client.h
index d9040fb3550..e644924389b 100644
--- a/ctdb/include/ctdb_client.h
+++ b/ctdb/include/ctdb_client.h
@@ -246,8 +246,6 @@ int ctdb_ctrl_getdbname(struct ctdb_context *ctdb, struct timeval timeout,
 int ctdb_ctrl_getdbhealth(struct ctdb_context *ctdb, struct timeval timeout,
 			  uint32_t destnode, uint32_t dbid,
 			  TALLOC_CTX *mem_ctx, const char **reason);
-int ctdb_ctrl_getdbseqnum(struct ctdb_context *ctdb, struct timeval timeout,
-			  uint32_t destnode, uint32_t dbid, uint64_t *seqnum);
 
 int ctdb_ctrl_createdb(struct ctdb_context *ctdb, struct timeval timeout,
 		       uint32_t destnode, TALLOC_CTX *mem_ctx,
-- 
2.16.3