[PATCH] Fix strict aliasing warnings in ctdb_client

Andreas Schneider asn at samba.org
Fri Apr 27 14:47:10 UTC 2018


Hi,

see attached.


Review much appreciated.


Thanks,


	Andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
>From 8b8e0ee736a0eb4aa1047f84db590edce76e5cdd Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn at samba.org>
Date: Fri, 27 Apr 2018 16:43:04 +0200
Subject: [PATCH] ctdb: Fix strict aliasing warnings in ctdb_client

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13411

Signed-off-by: Andreas Schneider <asn at samba.org>
---
 ctdb/client/ctdb_client.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ctdb/client/ctdb_client.c b/ctdb/client/ctdb_client.c
index a7624b7e3c8..59d338aa158 100644
--- a/ctdb/client/ctdb_client.c
+++ b/ctdb/client/ctdb_client.c
@@ -1881,7 +1881,7 @@ int ctdb_ctrl_getdbseqnum(struct ctdb_context *ctdb, struct timeval timeout,
 	TDB_DATA data, outdata;
 	uint8_t buf[sizeof(uint64_t)] = { 0 };
 
-	*(uint32_t *)buf = dbid;
+	SIVAL(buf, 0, dbid);
 	data.dptr = buf;
 	data.dsize = sizeof(uint64_t);
 
@@ -1899,7 +1899,7 @@ int ctdb_ctrl_getdbseqnum(struct ctdb_context *ctdb, struct timeval timeout,
 	}
 
 	if (seqnum != NULL) {
-		*seqnum = *(uint64_t *)outdata.dptr;
+		*seqnum = BVAL(outdata.dptr, 0);
 	}
 	talloc_free(outdata.dptr);
 
-- 
2.16.3



More information about the samba-technical mailing list