[PATCH] ctdb-tools: Avoid filtering stderr when onnode not running in parallel

Amitay Isaacs amitay at gmail.com
Fri Apr 27 04:53:24 UTC 2018

On Thu, Apr 26, 2018 at 8:12 PM, Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:
> stderr_filter() only does anything useful when running in
> parallel (i.e. with the -p option).  So, simplify the non-parallel
> case by not using stderr_filter().
> As a side-effect, this fixes an issue introduced in commit
> 85a4375788d8ef8345ec390807f18299abdadb20 where local daemon tests
> would hang when trying to start daemons with VALGRIND set (to a
> valgrind command that does not use --log-file).  This is because
> valgrind would keep stderr open for its output so the pipeline
> involving stderr_filter() would never complete.
> Please review and maybe push...
> peace & happiness,
> martin

Pushed to autobuild.


More information about the samba-technical mailing list