[PATCH] ctdb-tools: Avoid filtering stderr when onnode not running in parallel

Martin Schwenke martin at meltin.net
Thu Apr 26 10:12:11 UTC 2018

stderr_filter() only does anything useful when running in
parallel (i.e. with the -p option).  So, simplify the non-parallel
case by not using stderr_filter().

As a side-effect, this fixes an issue introduced in commit
85a4375788d8ef8345ec390807f18299abdadb20 where local daemon tests
would hang when trying to start daemons with VALGRIND set (to a
valgrind command that does not use --log-file).  This is because
valgrind would keep stderr open for its output so the pipeline
involving stderr_filter() would never complete.

Please review and maybe push...

peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ctdb-tools-Avoid-filtering-stderr-when-onnode-not-ru.patch
Type: text/x-patch
Size: 1354 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180426/afdc3019/0001-ctdb-tools-Avoid-filtering-stderr-when-onnode-not-ru.bin>

More information about the samba-technical mailing list