[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers

Martin Schwenke martin at meltin.net
Wed Apr 25 08:40:48 UTC 2018

On Wed, 25 Apr 2018 08:03:49 +0200, Ralph Böhme <slow at samba.org> wrote:

> On Wed, Apr 18, 2018 at 09:14:07AM +1000, Martin Schwenke via samba-technical wrote:
> > On Wed, 11 Apr 2018 11:59:45 +0200, Ralph Böhme via samba-technical
> > <samba-technical at lists.samba.org> wrote:  
> > > On Wed, Apr 11, 2018 at 10:04:32AM +0200, Stefan Metzmacher wrote:  
>  [...]  
> > > 
> > > Added to both hook and script.
> > > 
> > > Updated patch attached, please push if happy. Thanks!  
> > 
> > I notice this hasn't gone in yet.  Metze, are you happy with it?  
> also, how does/will this align with what Simo is proposing?

I think this should go in now to avoid the problem we were actually

I think Simo's tool should go in too so that we can play with it.  I've
already used it to clean up some of my commits.  Those who have enough
courage can add it to their commit hook (possibly ignoring the result
and using it to provide warnings).  Eventually we can even look at
adding it to tests.

However, I think we need something simple now, while we work on the
long term solution and long term approach.

peace & happiness,

More information about the samba-technical mailing list