[PATCH] Add utilities to check style

Swen Schillig swen at vnet.ibm.com
Tue Apr 24 06:51:27 UTC 2018


On Mon, 2018-04-23 at 11:48 -0400, Simo via samba-technical wrote:
> On Mon, 2018-04-23 at 16:13 +1000, Martin Schwenke wrote:
> > On Sat, 21 Apr 2018 17:34:12 -0400, Simo via samba-technical
> > <samba-technical at lists.samba.org> wrote:
> > 
> > > > 
> > * The "Un-cuddled open brace" thing is going to be annoying
> > 
> >   If you're initialising an array of structures then I don't see
> > how
> >   you can avoid this warning.
> > 
> >   Similarly, when initialising a fairly long array of structures
> > you
> >   might want to have the values inline, with opening and closing
> > braces
> >   on the same line as the data.  However, this generates lots of
> >   complaints.  :-(
> 
> I do not see why we want this to be a thing to be honest,.
> 
> We do:
>   struct foo bar = {
>     data
>   }
> We do not do:
>   struct foo bar = 
>   {
>      data
>   }
> do we ?

what about 
  struct foo bar = {0};


Cheers Swen 




More information about the samba-technical mailing list