[PATCH] Add utilities to check style

Simo simo at samba.org
Mon Apr 23 15:55:40 UTC 2018

so here my assesment:

it is perl,
it is very kernel specific,
also it is perl,
has checks for a lot of things we really do not care for,
also... it is perl,
it seem more concerned about patch submission than style,
and it is also perl ...

So I do  not know if this tool would be really valuable, but it is
perl, and I am certainly not going to relearn that "thing" :-)


On Mon, 2018-04-23 at 10:43 -0500, Steve French via samba-technical
> I have been impressed with scripts/checkpatch.pl (other than it is
> perl and 10 times larger - it covers a lot more common errors and
> style nits).  https://wintergreenworks.wordpress.com/2012/05/30/checkpatch-linux-coding-style-check/
> In addition, sparse has been invaluable in catching endian errors and
> 32-->64 bit overflow issues and lots of common C errors.    Has anyone
> looked at using these for Samba?
> On Sat, Apr 21, 2018 at 4:08 PM, Simo via samba-technical
> <samba-technical at lists.samba.org> wrote:
> > New revision of the patch to check style.
> > 
> > Martin I commented out the checks for the two behaviors you pointed
> > out.
> > 
> > Can I get a review so we can push this in and move to the next step ?
> > 
> > Simo.

More information about the samba-technical mailing list