[PATCH] Remove loadparm dependency from dbwrap

Swen Schillig swen at vnet.ibm.com
Wed Apr 18 06:20:27 UTC 2018


On Wed, 2018-04-18 at 08:05 +0200, Volker Lendecke via samba-technical
wrote:
> On Wed, Apr 18, 2018 at 08:00:09AM +0200, Swen Schillig wrote:
> > Hi Volker
> > On Wed, 2018-04-18 at 07:54 +0200, Volker Lendecke via samba-
> > technical
> > wrote:
> > > Hi!
> > > 
> > > $SUBJECT says it all. If requested, we can squash a few of the
> > > patches.
> > > 
> > > Review appreciated!
> > > 
> > 
> > Would it make sense to create a define for the default permission
> > "0600" and remove the magic number ?
> 
> Possibly. But that's not the focus of this patchset. The focus of
> this
> patchset is to remove the calls to lpctx_* from lib/dbwrap/. To have
> the patchset exactly on this topic, I tried to avoid changing other
> parameters.
> 
> If you want to also change the default permission specification, feel
> free to propose a separate patchset.
> 
> Volker
> 
You're right. Sorry for proposing a "while-at-it" strategy again.
We've left that behind us.

Cheers Swen

P.S.: I won't provide a patch "fixing" those as I've promised to not
send in cleanup patches for a while.




More information about the samba-technical mailing list