Fwd: [PATCHES] simple gpo patches fixes
douglas.bagnall at catalyst.net.nz
Tue Apr 17 23:20:30 UTC 2018
On 14/04/18 02:19, David Mulder via samba-technical wrote:
> I've added that type check, as well as couple other checks. I also
> wasn't checking the ads type input or verifying the list and it's length
> before popping from it. Latest sources are on the github pull request.
Thanks. The ADS check is definitely necessary.
I thought the list was OK without the checks (in that you'd get a Python
exception from PyList_GetItem(), not a segfault), but I see that you're
accepting an empty list, so you do need more checks.
1. Is there a test for the empty list?
2. If you're only ever looking at the first item, why is it a list?
The first question is a "there should be" hint, but the second one is a
genuine question from a GPO ignoramus.
More information about the samba-technical