[Patch v2 2/6] cifs: Allocate validate negotiation request through kmalloc
smfrench at gmail.com
Tue Apr 17 20:37:10 UTC 2018
On Tue, Apr 17, 2018 at 3:11 PM, Long Li via samba-technical
<samba-technical at lists.samba.org> wrote:
>> Subject: RE: [Patch v2 2/6] cifs: Allocate validate negotiation request through
>> > -----Original Message-----
>> > From: linux-rdma-owner at vger.kernel.org [mailto:linux-rdma-
>> > owner at vger.kernel.org] On Behalf Of Long Li
>> > Sent: Tuesday, April 17, 2018 2:17 PM
>> > To: Steve French <sfrench at samba.org>; linux-cifs at vger.kernel.org;
>> > samba- technical at lists.samba.org; linux-kernel at vger.kernel.org; linux-
>> > rdma at vger.kernel.org
>> > Cc: longli <longli at microsoft.com>; stable at vger.kernel.org
>> > Subject: [Patch v2 2/6] cifs: Allocate validate negotiation request
>> > through kmalloc
>> > From: Long Li <longli at microsoft.com>
>> > The data buffer allocated on the stack can't be DMA'ed, and hence
>> > can't send through RDMA via SMB Direct.
>> > Fix this by allocating the request on the heap in smb3_validate_negotiate.
>> > Fixes: ff1c038addc4f205d5f1ede449426c7d316c0eed "Check SMB3 dialects
>> > against downgrade attacks"
>> Format is:
>> Fixes: ff1c038addc4 ("Check SMB3 dialects against downgrade attacks") It
>> should be right above Signed-off signature.
> I will fix up and resend this patch.
> How about the rest patches (1, 3-6) in the series? If they don't need any changes, is it okay that I resend this one only?
Doesn't matter to me either way - I already merged patch 1 in any case.
>> > Changes in v2:
>> > Removed duplicated code on freeing buffers on function exit.
>> > (Thanks to Parav Pandit <parav at mellanox.com>)
More information about the samba-technical