[PATCH 5/6] cifs: smbd: Enable signing with smbdirect

Long Li longli at microsoft.com
Tue Apr 17 18:57:12 UTC 2018

It’s a good idea to cc:stable.

From: Steve French <smfrench at gmail.com>
Sent: Monday, April 16, 2018 8:32 PM
To: Long Li <longli at microsoft.com>
Cc: Steve French <sfrench at samba.org>; CIFS <linux-cifs at vger.kernel.org>; samba-technical at lists.samba.org; linux-kernel at vger.kernel.org; linux-rdma at vger.kernel.org; stable at vger.kernel.org
Subject: Re: [PATCH 5/6] cifs: smbd: Enable signing with smbdirect

Thoughts on cc:stable?

On Mon, Apr 16, 2018, 20:02 Long Li <longli at linuxonhyperv.com<mailto:longli at linuxonhyperv.com>> wrote:
From: Long Li <longli at microsoft.com<mailto:longli at microsoft.com>>

Now signing is supported with RDMA transport.

Remove the code that disabled it.

Signed-off-by: Long Li <longli at microsoft.com<mailto:longli at microsoft.com>>
 fs/cifs/connect.c | 8 --------
 fs/cifs/smb2pdu.c | 4 ----
 2 files changed, 12 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index e8830f0..deef270 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1977,14 +1977,6 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
                goto cifs_parse_mount_err;

-       if (vol->rdma && vol->sign) {
-               cifs_dbg(VFS, "Currently SMB direct doesn't support signing."
-                       " This is being fixed\n");
-               goto cifs_parse_mount_err;
-       }
 #ifndef CONFIG_KEYS
        /* Muliuser mounts require CONFIG_KEYS support */
        if (vol->multiuser) {
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 6759035..d71ce51 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -737,10 +737,6 @@ int smb3_validate_negotiate(const unsigned int xid, struct cifs_tcon *tcon)

        cifs_dbg(FYI, "validate negotiate\n");

-       if (tcon->ses->server->rdma)
-               return 0;
        pneg_inbuf = kmalloc(sizeof(*pneg_inbuf), GFP_KERNEL);
        if (!pneg_inbuf)
                return -ENOMEM;

To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo at vger.kernel.org<mailto:majordomo at vger.kernel.org>
More majordomo info at  http://vger.kernel.org/majordomo-info.html<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.kernel.org%2Fmajordomo-info.html&data=02%7C01%7Clongli%40microsoft.com%7C299ea1f40e9343bf280c08d5a413cdf2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636595327334161489&sdata=PPNXoJ9vzj1Zoh%2B8SN6hqd3tUfxMyhIWxVgqRCo03rg%3D&reserved=0>

More information about the samba-technical mailing list