[PATCH] Fix two CIDs

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Apr 16 13:31:22 UTC 2018

On Mon, Apr 16, 2018 at 03:25:44PM +0200, Stefan Metzmacher via samba-technical wrote:
> Hi Volker,
> as written before
> https://lists.samba.org/archive/samba-technical/2018-April/126715.html

Ok. Sorry for re-posting. I had missed your NACK.

> This looks wrong, in tstream_smbXcli_np_readv_trans_done()
> you can also remove TALLOC_FREE(subreq), as that's already called
> a few lines above, but in tstream_smbXcli_np_readv_read_done()
> we need to keep this or rework smb1cli_readx_recv() to take a memory
> context, so that we don't have to defer TALLOC_FREE(subreq);
> The problem is that TALLOC_FREE(subreq); will crash as
> it will be implicitly free'ed via the callback triggered by
> tevent_req_nomem().

Wow, that's really complex logic. We should turn the tevent_req_nomem
into tevent_req_oom as done elsewhere. This returns void.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list