[PATCH] Fix two CIDs
Stefan Metzmacher
metze at samba.org
Mon Apr 16 13:25:44 UTC 2018
Hi Volker,
as written before
https://lists.samba.org/archive/samba-technical/2018-April/126715.html
This looks wrong, in tstream_smbXcli_np_readv_trans_done()
you can also remove TALLOC_FREE(subreq), as that's already called
a few lines above, but in tstream_smbXcli_np_readv_read_done()
we need to keep this or rework smb1cli_readx_recv() to take a memory
context, so that we don't have to defer TALLOC_FREE(subreq);
The problem is that TALLOC_FREE(subreq); will crash as
it will be implicitly free'ed via the callback triggered by
tevent_req_nomem().
metze
Am 16.04.2018 um 15:22 schrieb Volker Lendecke via samba-technical:
> Hi!
>
> Review appreciated!
>
> Thanks, Volker
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180416/097b4d06/signature.sig>
More information about the samba-technical
mailing list