[PATCH] check types rather than segfault in pygpo.c
abartlet at samba.org
Fri Apr 13 06:04:40 UTC 2018
On Fri, 2018-04-13 at 17:36 +1200, Douglas Bagnall wrote:
> On 13/04/18 14:45, Andrew Bartlett via samba-technical wrote:
> > On Fri, 2018-04-13 at 14:39 +1200, Douglas Bagnall via samba-technical
> > wrote:
> > > I was trying to find good examples for another thread, and only found bad.
> > >
> > > Douglas
> > Thanks Douglas!
> > Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> > Please push!
> Actually it is better like this, with the test squashed into the fix (or
> I guess omitted altogether), because the knownfail entry doesn't cope
> with the segfault, so we'd have a failure between those commits.
This is also quite fine. Thanks!
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
More information about the samba-technical