[PATCHSET] more python 3

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Thu Apr 12 11:53:10 UTC 2018


On 12/04/18 22:38, Noel Power via samba-technical wrote:
> Hi Douglas
> On 12/04/18 06:53, Douglas Bagnall wrote:
>> Hi Noel,
>>
>> I was preparing to push this patchset but noticed that one in the middle
>> lacks your sign-off:
>>
>>
>>     python/wscript: build grouping library for py2/py3 (--extra-python)
>>
>>     Grouping library is not used for any delivered libraries, however
>>     it is used internally when building local libraries used when
>>     "make test TESTS='blah'" is invoked. Failure to provide the grouping
>>     library results in missing symbols (and cores) when running tests
> oops, sorry about that
>>
>>
>> If you can add a Signed-off-by, you can also add my review.
> thanks alot!
> please find attached updated patch

No worries. 

Note that if you are happy with Joe's patches, you should be able to add
your review and push the lot to autobuild. Otherwise I will look again
tomorrow.

cheers,
Douglas



More information about the samba-technical mailing list