[PATCH] initialise optional parameters in Python-C bindings

Andrew Bartlett abartlet at samba.org
Thu Apr 12 07:12:25 UTC 2018

On Thu, 2018-04-12 at 18:11 +1200, Douglas Bagnall via samba-technical
> I noticed today how easy it is to leave a variable uninitialised using
> the PyArg_ParseTuple* functions with the "|" token, and how disguised
> this unsetness is hidden from both static checkers and people's eyes.
> The "|" means all the rest of the arguments are optional and the
> corresponding C variables won't be changed if they are omitted.
> I applied some grep and found the following.
> Douglas

Looks great.  Reviewed-by: Andrew Bartlett <abartlet at samba.org> and
pushed to autobuild.

Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list