[PATCH] LMDB full patch set

Andrew Bartlett abartlet at samba.org
Wed Apr 11 22:44:11 UTC 2018

On Thu, 2018-04-12 at 07:05 +1200, Andrew Bartlett wrote:
> On Wed, 2018-04-11 at 14:15 +0200, Stefan Metzmacher via samba-
> technical wrote:
> > I'd like to have a look, but that might take a few days.
> Can you please be specific?  Last week you said you would have feedback
> for me in a day, and it has been over a week.
> > And as you seem to still find bugs, I don't understand why this needs
> > to get to master as soon as possible. 
> I've not found any bugs in the LMDB patch set.  It has not changed
> since the re-order you requested last week. 
> What I have done is address yet another serious locking bug.  Indeed
> rare but existing locking bugs have taken up most of the time for this
> project!
> Perhaps it happens more often with this patch, or perhaps it is just
> like the branch point before Samba 4.8 where flapping tests came out of
> nowhere.  Either way, what I've done is find and fix it.
> (Gary did his due testing the entire time he was testing, and when he
> first proposed it, and they didn't fail then). 
> > The branch point for 4.9.0rc1
> > won't happen in near future.
> I really, really don't want to leave this any longer.  I've got a set
> of patches that pass the Gitlab CI.  They also show good results on
> Catalyst Cloud autobuilds, results being:
> lmdb-pre-7:
>  - 2 success
>  - nt4_dc notify
> abartlet-lmdb-reordered-2:
>  - 3 success
>  - samba4.rpc.altercontext on ncalrpc with seal,padcheck.altercontext
> dsheuristics-userpassword:
>  - 2 success
> I've got 7 more builds of abartlet-lmdb-reordered-2 running now to be
> sure.  Once I get those back, I really want to land this.

The status on those were:
 - 5 success
 - samba3.smb2.lease(nt4_dc)
 - samba.tests.blackbox.samba_dnsupdate(chgdcpass:local)

Therefore I think this is ready, as far as testing shows.  Frankly I
think I've probably fixed some of our long-standing flapping issues in
the AD DC, but only time will really tell on that. 

> For a number of reasons, I can't keep ploughing time into this.
> That said, I realise you have put this aside into the 'don't need to
> look at right now' category, but I've addressed the concerns you raised
> and I do think anything else can be done after it lands in master.
> All I'm asking is that you allow me to get review from other team
> members.
> Thanks,
> Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list