[RFC] incorrect dosmode on stream associated with dir
jra at samba.org
Wed Apr 11 17:32:26 UTC 2018
On Wed, Apr 11, 2018 at 08:37:51AM -0700, Jeremy Allison via samba-technical wrote:
> On Wed, Apr 11, 2018 at 09:50:38AM +0200, Volker Lendecke via samba-technical wrote:
> > On Tue, Apr 10, 2018 at 05:10:00PM -0700, Jeremy Allison via samba-technical wrote:
> > > OK, I think the following is the "minimal" correct fix.
> > RB+ on the patch, please add a commit message :-)
> Thanks - pushed. I'm still planning to add a regression
> test in the smbclient test suite for this, but I've logged
> bug: https://bugzilla.samba.org/show_bug.cgi?id=13380
> and that shouldn't block the fix going into master and
> release branches.
Ha. Never push without a regression test :-).
Now I have a test, the fix is a little more
complicated than my original simple change
(which is still correct, just not complete,
hint - 4.7.x and above uses a VFS call
get_dos_attributes_fn() to pull attributes,
only uses the stat struct as a fallback).
Cancelled my push and will post a complete patch
+ regression test to follow :-).
More information about the samba-technical