[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers
martin at meltin.net
Wed Apr 11 02:10:18 UTC 2018
On Tue, 10 Apr 2018 14:45:24 +0200, Ralph Böhme <slow at samba.org> wrote:
> On Tue, Apr 10, 2018 at 02:38:36PM +0200, Ralph Böhme wrote:
> > On Tue, Apr 10, 2018 at 02:29:41PM +0200, Swen Schillig wrote:
> > > Ralph, don't you need to add that "--cached" parameter to your script
> > > as well ?
> > > As stated in one of my earlier mails, I believe you need that 'cause
> > > otherwise all modified files are checked and not just the ones which
> > > are part of the commit (were add'ed before).
> > are you sure? It's a commit hook after all so my expectation was it only check
> > what I commit. I'll check...
> d'oh! You're obviously right...
> Updated patch attached.
Reviewed-by: Martin Schwenke <martin at meltin.net>
We can followup with a patch to make it work under magit, probbaly via:
Alternatively, if others agree then this can go in now.
peace & happiness,
More information about the samba-technical