[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers

[Andrew Bartlett]

On Tue, 2018-04-10 at 21:54 +0200, Ralph Böhme via samba-technical
wrote:
> On Tue, Apr 10, 2018 at 09:27:50AM -0700, Jeremy Allison wrote:
> > On Tue, Apr 10, 2018 at 02:45:24PM +0200, Ralph Böhme via samba-technical wrote:
> > > On Tue, Apr 10, 2018 at 02:38:36PM +0200, Ralph Böhme wrote:
> > > > On Tue, Apr 10, 2018 at 02:29:41PM +0200, Swen Schillig wrote:
> > > > > Ralph, don't you need to add that "--cached" parameter to your script
> > > > > as well ?
> > > > > As stated in one of my earlier mails, I believe you need that 'cause
> > > > > otherwise all modified files are checked and not just the ones which
> > > > > are part of the commit (were add'ed before).
> > > > 
> > > > are you sure? It's a commit hook after all so my expectation was it only check
> > > > what I commit. I'll check...
> > > 
> > > d'oh! You're obviously right...
> > > 
> > > Updated patch attached.
> > 
> > OK, where are we with this ? Are we able to commit this
> > as it seems to solve the immediate problem ?
> > 
> > Sure we can add more stuff later, but consider this
> > a RB+ from me (and when can we push ? :-).
> 
> Thanks! I'd like to see broader consensus before we push this. metze? Douglas?
> Martin? Andrew? Volker?

I'll give it a try but the concept looks good, being local, immediate,
softly enforced and automated.

Making the broader tree comply will be a longer task, but one I think
we should take on also.

Thanks Douglas,

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba