[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers
Martin Schwenke
martin at meltin.net
Tue Apr 10 21:44:18 UTC 2018
On Tue, 10 Apr 2018 22:34:18 +1000, Martin Schwenke <martin at meltin.net>
wrote:
> On Tue, 10 Apr 2018 14:22:18 +0200, Ralph Böhme <slow at samba.org> wrote:
>
> > On Tue, Apr 10, 2018 at 09:32:24PM +1000, Martin Schwenke wrote:
> > > Hmmm... that said, Douglas' pre-commit hook doesn't work under magit.
> > > It works if I don't specify any paths. For some reason it doesn't
> > > trigger if I do add the paths that match C and/or Python files. I
> > > think there's some subtlety in the way the paths are specified in the
> > > environment magit is running git in. :-(
> >
> > yeah, I noticed that as well but haven't looked into it. As a heavy magit user
> > myself, I'll ensure to get this working from within magit. :)
>
> Cool! :-)
>
> I opened this and got an initial response:
>
> https://github.com/magit/magit/issues/3419
As per that issue, the neatest solution seems to be to do this near the
top of the script:
unset GIT_LITERAL_PATHSPECS
peace & happiness,
martin
More information about the samba-technical
mailing list