[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Tue Apr 10 19:50:47 UTC 2018

On 10/04/18 21:58, Stefan Metzmacher wrote:

>>> I think we should use some like wireshark,
>>> were the real script[s] are part of the checkout and the pre-commit hook
>>> is just a wrapper arround it, that way we can improve the script step by
>>> step.
>>> See
>>> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=tools/pre-commit
>> Yes.
>> Of course, a difficulty we have that wireshark and other projects
>> don't is 17655 lines of C with trailing whitespace and nearly 50k
>> lines over 80 characters, which we don't want to change all at once. I
>> think the wireshark scripts check the whole of the affected file on
>> the assumption that everything you didn't change will still be
>> perfectly formatted. Our scripts will have to fiddle around with
>> diffs.
> I'm not proposing to use the wireshark scripts, I haven't looked at them
> in details.

Yeah, I got that and agree -- I was just drifting off on a tangent.
> The logic for using a script that is part of the checkout and having a
> .git/hook/pre-commit script that just calls into the working tree
> is what I'd like to have (and maybe the logic to detect an outdated script)

If this hasn't been fixed overnight, could we just make the hook a
symlink into the tree rather than a copy?


More information about the samba-technical mailing list