[PATCH] Speed up tdbtool erase

Jeremy Allison jra at samba.org
Tue Apr 10 19:47:28 UTC 2018

On Tue, Apr 10, 2018 at 05:12:40PM +0200, Volker Lendecke via samba-technical wrote:
> Hi!
> Review appreciated!

From the code change:

>> I think the speed advantage outweighs this disadvantage.

So do I :-). RB+ and pushed.

> On top of that: I'm wondering if we can't truncate a tdb file in
> wipe_all. What we might need to do is to readjust the mmap size in
> tdb_expand(). The only place where we might face SIGBUS would be from
> tdb_allocate_from_freelist figuring out the freelist can't fit our
> needs. This is (I believe) the only place in the code where we would
> enter file space that might not exist yet.
> Comments?

Hmmm. Gonna have to think about that some more :-).


More information about the samba-technical mailing list