[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers

[Swen Schillig]

On Tue, 2018-04-10 at 14:20 +0200, Ralph Böhme via samba-technical
wrote:
> On Tue, Apr 10, 2018 at 02:16:41PM +0200, Ralph Böhme wrote:
> > On Tue, Apr 10, 2018 at 09:32:24PM +1000, Martin Schwenke wrote:
> > > On Tue, 10 Apr 2018 11:58:18 +0200, Stefan Metzmacher via
> > > samba-technical <samba-technical at lists.samba.org> wrote:
> > > 
> > > > The logic for using a script that is part of the checkout and
> > > > having a
> > > > .git/hook/pre-commit script that just calls into the working
> > > > tree
> > > > is what I'd like to have (and maybe the logic to detect an
> > > > outdated script)
> > > 
> > > I think this is a good approach.  This allows us to refine the
> > > tool or
> > > even a choice/combination of tools.  There is a question about
> > > how to do
> > > this neatly...
> > 
> > hold right there, I'll post something in a minute... :)
> 
> here we go.
> 
> With the attached patchset I get this:
> 
> [slow at kazak scratch]$ git diff --cached           
> diff --git a/source4/torture/smb2/durable_v2_open.c
> b/source4/torture/smb2/durable_v2_open.c         
> index 13316eb3f8b..f4df0a97983 100644             
> --- a/source4/torture/smb2/durable_v2_open.c      
> +++ b/source4/torture/smb2/durable_v2_open.c      
> @@ -2121,7 +2121,7 @@ static bool
> test_persistent_reconnect_lease(struct torture_context *tctx,      
>                  */                               
>  //             TALLOC_FREE(tree);                
>                 torture_comment(tctx, "Got PH, waiting for cluster
> kill...\n");                      
> -               getchar();                        
> +               getchar();                        
>                 torture_comment(tctx, "Trying to reconnect PH on new
> connection\n");                 
> 
>                 /*                                
Ralph, don't you need to add that "--cached" parameter to your script
as well ?
As stated in one of my earlier mails, I believe you need that 'cause
otherwise all modified files are checked and not just the ones which
are part of the commit (were add'ed before).

Cheers Swen