[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers

Martin Schwenke martin at meltin.net
Tue Apr 10 11:32:24 UTC 2018

On Tue, 10 Apr 2018 11:58:18 +0200, Stefan Metzmacher via
samba-technical <samba-technical at lists.samba.org> wrote:

> The logic for using a script that is part of the checkout and having a
> .git/hook/pre-commit script that just calls into the working tree
> is what I'd like to have (and maybe the logic to detect an outdated script)

I think this is a good approach.  This allows us to refine the tool or
even a choice/combination of tools.  There is a question about how to do
this neatly...

The "git commit --no-verify" option to avoid the pre-commit hook can
even be easily done when committing using magit under Emacs (and perhaps
also with the git support for vim).

Hmmm... that said, Douglas' pre-commit hook doesn't work under magit.
It works if I don't specify any paths.  For some reason it doesn't
trigger if I do add the paths that match C and/or Python files.  I
think there's some subtlety in the way the paths are specified in the
environment magit is running git in.  :-(

Any other magit users on the team who might have a clue about this?

peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180410/78ef771c/attachment.sig>

More information about the samba-technical mailing list