[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers
abartlet at samba.org
Tue Apr 10 11:28:31 UTC 2018
On Tue, 2018-04-10 at 13:24 +0200, Ralph Böhme via samba-technical
> On Tue, Apr 10, 2018 at 01:09:38PM +0200, Swen Schillig wrote:
> > On Tue, 2018-04-10 at 12:50 +0200, Ralph Böhme via samba-technical
> > wrote:
> > > On Tue, Apr 10, 2018 at 11:36:04AM +0200, Swen Schillig wrote:
> > > > I promise I will mention it only this one time again, but what
> > > > about using
> > > > checkpatch instead of reinventing the wheel ?
> > > >
> > > > checkpatch is used in a variety of other non-kernel projects,
> > > > like GANESHA (user space NFS server) which is a project with
> > > > very similar requirements.
> > > >
> > > > So why not having a look at least ?
> > >
> > > heavens, that's 6k+ lines of Perl and a lot of it is really kernel
> > > specific.
> > >
> > True, but is it not better to have matured 6k LOC which
> > we don't have to maintain vs 500 LOC where we do ?
> I guess in the end we will have to maintain a copy as well. I haven't looked in
> detail, but I guess we will need changes to checkpatch as well. So it means
> maintaining a few hundred clean Python lines of a few thousand Perl.
The python check-file.py script looked practical to adapt into a
standard Samba test for if/when we choose to make some files in samba
permanently comply with some/all of the results. If adapted to speak
subunit it would also fit into the flapping/knownfail/skip system we
I suspect the linux kernel and Samba styles (as found in current 'good'
code, not just the rule-book) have diverged also, but I've not checked
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical