[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Tue Apr 10 09:03:19 UTC 2018

On 10/04/18 18:30, Ralph Böhme wrote:
> On Mon, Apr 09, 2018 at 08:44:10AM -0700, Jeremy Allison via samba-technical wrote:
>> Thanks very much Douglas, this looks like it might be a great
>> solution that works for all ! Thanks very much for helping out
>> with this contentious issue.
>> I'll test it out and push if happy.
> +1 from my side.
> Wonder whether we still need the more complex checking tool from Simo given that
> the original issue that started the outrage would be addressed by Douglas'
> patch.

I think there is a place for a more sophisticated tool that can be run manually.
I haven't looked closely at Simo's patch, but it sounds like it has pedigree. 

When I am reviewing or working on python files, I quite often run flake8 to see
what it says. I don't always agree. It would be nice to have a similar thing for C.
It is sometimes more interesting for a tool to be opinionated than authoritative.

I also agree that the git-commit hook could do more than check whitespace.


More information about the samba-technical mailing list