[PATCH] Provide a simple backtrace in the samba AD DC also

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Apr 10 06:11:47 UTC 2018

On Tue, Apr 10, 2018 at 05:00:32PM +1200, Andrew Bartlett via samba-technical wrote:
> smbd has for a long time been able to produce a simple internal
> backtrace.
> This patch allows 'samba' to do the same, by bringing that code into
> lib/util.  An un-used IRIX mode, lost since the move to waf, was
> removed to allow this to happen.  (That mode used become_root()). 
> This is important because gdb_backtrace as a panic action is not
> compatible with gitlab CI, so without this we have no way to tell where
> the fault is. 
> The cstyle.py failures are all in the moved code:
> ad84ecfd836 s3-lib: Remove support for libexc for IRIX backtraces
> 2469ab654a3 lib/util: Log PANIC before calling pacic action just like
> s3
> 212ae4db4bb lib/util: Move log_stack_trace() to common code

Why do you have to move this to common code? The waf targets in
source3/ are available everywhere. I'm asking because this relocation
makes "git blame" harder to follow, at least with my limited knowledge
of git.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list