[PATCH] Improve password_hash.c error message with invalid krb5.conf

William Brown william at blackhats.net.au
Tue Apr 10 05:34:09 UTC 2018


On Tue, 2018-04-10 at 17:23 +1200, Andrew Bartlett wrote:
> On Tue, 2018-04-10 at 14:53 +1000, William Brown via samba-technical
> wrote:
> > This patch resolves the earlier issue I found where the ldb
> > operations
> > error did not clearly communicate the issue.
> > 
> > Thank you for your time,
> > 
> > William Brown
> 
> Thanks William,
> 
> Can you add a Signed-off-by per the copyright policy and contributing
> page on the wiki?

> 
> Also, keep the line lengths under 80 columns and (if any) avoid
> trailing whitespace. 
> 
> I'll look at this more tomorrow, but it looks good so far!

Fixed both comments, see new patch attached,

Thank you!

> 
> Andrew Bartlett
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-ldb-password_hash.c-improve-krb5-context-error-me.patch
Type: text/x-patch
Size: 2018 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180410/492bb1d4/0001-s4-ldb-password_hash.c-improve-krb5-context-error-me.bin>


More information about the samba-technical mailing list