[RFC] incorrect dosmode on stream associated with dir

[Jeremy Allison]

On Mon, Apr 09, 2018 at 06:55:25PM -0400, Andrew Walker via samba-technical wrote:
> Hi all,
> 
> Some of our users have reported that in the following situation:
> (1) streams_xattr was enabled,
> (2) store dos attributes = yes,
> and
> (3) stream exists on a directory (i.e. Dir:AFP_AfpInfo)
> 
> when they try to copy "Dir" in File Explorer on a Windows 7 clients,
> Windows displays "invalid MS-DOS function" and fails to copy the directory
> in question. Windows 10, Server 2016 are not affected.
> 
> Packet captures indicated that in the above situation Samba is setting
> FILE_ATTRIBUTE_DIRECTORY on Dir:AFP_AfpInfo in the related GetInfo
> response. Note that from what I have observed, Windows servers do not set
> this attribute.
> 
> I applied the attached patch and it fixed the above behavior.

Oh that's a good catch - thanks ! We'll need to pair it with
a regression test to ensure we keep it fixed in future.