Whitespace and bullying

Martin Schwenke martin at meltin.net
Mon Apr 9 12:41:08 UTC 2018


On Mon, 09 Apr 2018 14:28:45 +0200, Swen Schillig <swen at vnet.ibm.com>
wrote:

> On Mon, 2018-04-09 at 21:11 +1000, Martin Schwenke via samba-technical
> wrote:

> > Swen's suggestion of using the kernel's checkpatch is reasonable, but
> > the code will require modifications.  It doesn't cope with more than
> > one file in a patch,   

> No, what makes you think so ?

Sorry, typo.  I meant more than 1 commit in a patch file.  It barfs
because it thinks the Signed-off-by: tags for most of the commits are
duplicates.

Yes, it can be worked around...  but I think the kernel checkpatch.pl
makes too many kernel-related assumptions...

peace & happiness,
martin



More information about the samba-technical mailing list