Patch for memory leak in vfs_defaults.c
jra at samba.org
Fri Apr 6 23:22:55 UTC 2018
On Sat, Apr 07, 2018 at 12:50:48AM +0200, Timur I. Bakeyev via samba-technical wrote:
> Yes, while the fix is trivial by itself, it took a lot of time to locate
> the leak and Andrew did a tremendous work to nail it and fix.
Absolutely ! That's why I want his name on it - as I'm the one
who introduced the bug in the first place, I certainly shouldn't
be the author :-).
> Finding the leak also showed us that there is no good tooling to track
> memleaks in Samba, at least on FreeBSD. Both dmalloc and valgrind failed us
> on various reasons and only jemalloc helped to confirm at that point, that
> the right place was spotted.
Did valgrind not catch this ? That would have seemed the natural
tool to find the problem.
More information about the samba-technical