Patch for memory leak in vfs_defaults.c
jra at samba.org
Fri Apr 6 22:44:17 UTC 2018
On Fri, Apr 06, 2018 at 06:41:59PM -0400, Andrew Walker via samba-technical wrote:
> On Fri, Apr 6, 2018 at 4:55 PM, Jeremy Allison <jra at samba.org> wrote:
> > On Fri, Apr 06, 2018 at 04:40:44PM -0400, Andrew Walker via
> > samba-technical wrote:
> > > Hi all,
> > > I encountered an issue where several FreeNAS users on samba 4.7 were
> > > experiencing memory leak resulting in single smbd process consuming all
> > > available RAM and swap space. Disabling the getwd cache significantly
> > > increased rate of leak, and enabling widelinks / disabling unix
> > extensions
> > > made the leak apparently stop. Investigation indicated that the leak was
> > in
> > > vfswrap_getwd().
> > >
> > > The attached patch resolved the issue.
> > Oh god that's *embarassing*. Looks like my fault too, sorry.
> > Thanks very much for finding that.
> > Can you try the attached patch instead and confirm it fixes it,
> > it's a smaller and simpler change.
> > Cheers,
> > Jeremy.
> That is actually the first patch I wrote when I was debugging the issue. It
> definitely works. :)
> The more complex patch was for consistency with vfswrap_realpath(), but I
> am not partial to either fix.
Oh in that case I'll put your name as authoer and get
a review and get it into the trees. Sorry for the mistake.
More information about the samba-technical