[PATCH] s3:smb2_tcon: Add check to prevent non-DFS clients from connecting to an msdfs proxy.

David Disseldorp ddiss at samba.org
Fri Apr 6 15:14:31 UTC 2018


On Fri, 6 Apr 2018 16:47:45 +0200, Ralph Wuerthner via samba-technical wrote:

> On 06.04.2018 16:27, Volker Lendecke wrote:
> > On Fri, Apr 06, 2018 at 04:24:33PM +0200, Swen Schillig via samba-technical wrote:
> >>> Another team reviewer?
> >>
> >> Really ?
> >> No README.Coding anymore ?
> >>
> >> Referring to Jeremy's latest requirement regarding
> >> function parameter list.
> > 
> > Ok, sorry, this is a copy&paste. NACK on this patch. Apologies.
> > 
> > Volker
> > 
> 
> No problem. Please see my updated version.

Please avoid leaking the proxy string onto the talloc_tos context.
This looks fine otherwise:
Reviewed-by: David Disseldorp <ddiss at samba.org>

Cheers, David



More information about the samba-technical mailing list