[PATCH] LMDB key value backend for ldb_tdb (to be renamed ldb_key_val)
abartlet at samba.org
Thu Apr 5 18:48:37 UTC 2018
On Fri, 2018-04-06 at 06:38 +1200, Andrew Bartlett via samba-technical
> On Thu, 2018-04-05 at 07:18 +1200, Andrew Bartlett via samba-technical
> > On Wed, 2018-04-04 at 17:54 +1200, Andrew Bartlett wrote:
> > > On Wed, 2018-04-04 at 06:57 +1200, Andrew Bartlett wrote:
> > > >
> > > > However I will work today to see if anything can be pulled forward
> > > > without upending the entire patch set. It may be possible to bring
> > > > some tests forward without the build hook for the lmdb mode, for
> > > > example.
> > >
> > > I've spend my entire work day today re-ordering the patch set. I hope
> > > this is now satisfactory, as I can't put much more time into this.
> > >
> > > Attached are two patches, one on top of the other patches sent today,
> > > and one with all the LDB patches I'm trying to get merged.
> > >
> > > Each patch compiles on its own and passes the ldb tests on its own.
> > >
> > > If you could let me know that you are happy that I've addressed your
> > > concerns as far as is practical that would be most appreciated.
> > > (Review comments also most welcome).
> > >
> > > The full CI results will be here:
> > > https://gitlab.com/catalyst-samba/samba/pipelines/19933665
> > Garming, this showed:
> > https://gitlab.com/catalyst-samba/samba/-/jobs/60989918
> > That is, a return to the imfamous 'failed to upgrade hash locks' on
> > TDB. Is this still something we get from time to time or should I look
> > into it more specifically?
> I've taken out three suspicious patches and got a pass on this branch:
> I plan on landing these preparatory patches today, while I wait for
> Metze's comments on the rest and debug which of the three suspicious
> patches is the issue.
> Metze: I trust this won't pre-empt any further comments you have on
> the actual LMDB change. On that wider patch set posted in the other
> thread, please let me know your thoughts or if you are happy for me to
> proceed without your specific review.
Sorry, I posted this on the wrong sub-thread. The wider patches are
those I posted here earlier. The patches I'm planning to land today
are some of those that Andreas said "Wow, this is great work and a load
of unit tests." about yesterday.
> Andrew Bartlett
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical