[PATCH] Allow GetDCNameEx to be called for arbitrary sites and trusted domains
Volker Lendecke
Volker.Lendecke at SerNet.DE
Thu Apr 5 06:33:25 UTC 2018
On Thu, Apr 05, 2018 at 08:23:42AM +0200, Volker Lendecke via samba-technical wrote:
> On Thu, Apr 05, 2018 at 11:29:41AM +1200, Garming Sam via samba-technical wrote:
> > source3/libsmb/clidgram.c: nbt_getdc_send
> >
> > state->nmbd_pid = pidfile_pid(lp_pid_directory(), "nmbd");
> > if (state->nmbd_pid == 0) {
> > DEBUG(3, ("No nmbd found\n"));
> > tevent_req_nterror(req, NT_STATUS_NOT_SUPPORTED);
> > return tevent_req_post(req, ev);
> > }
> >
> > So it seems that it relies on nmbd running in order to make any further
> > identification. This seems to be the expected code path, so selftest
> > must have some additional records or some other method that circumvents
> > this. I'm also not confident about the site-awareness of the above calls
> > that are being triggered. It is possible that someone actually has to do
> > the NETBIOS name to DNS name conversion at some layer to get this right.
> > The goal for me was to mostly just plumb the call and ensure the single
> > domain case works as expected.
>
> Well, this code path could go away very, pending review and
"very soon" of course :-)
Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical
mailing list