[PATCH] Refuse to commit a faulty reindex

Gary Lockyer gary at catalyst.net.nz
Wed Apr 4 19:04:43 UTC 2018


RB+

On 04/04/18 11:25, Andrew Bartlett via samba-technical wrote:
> The attached patches address a serious issue breaking upgrades to samba
> 4.8.
> 
> The re-index on the upgrade can fail (due to case-wise duplicate
> servicePrincipalName values), and if it does then the reindex does not
> complete, but the transaction around it can complete. 
> 
> This patch set ensures this cannot happen.  A part of the lmdb patch
> set is included to avoid making that patch set harder to land.
> 
> Please review and push.
> 
> CI results are as part of the larger branch here:
> 
> https://gitlab.com/catalyst-samba/samba/pipelines/19924329/builds
> 
> and this one of just these patches:
> https://gitlab.com/catalyst-samba/samba/pipelines/19925284
> 
> Andrew Bartlett
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180405/57d3a1d9/signature.sig>


More information about the samba-technical mailing list