[PATCH] Prepare for LMDB by improving ldb_tdb and Samba callers

[Andreas Schneider]

On Wednesday, 4 April 2018 07:24:28 CEST Andrew Bartlett via samba-technical 
wrote:
> On Wed, 2018-04-04 at 15:32 +1200, Gary Lockyer via samba-technical
> 
> wrote:
> > RB+ by me
> > 
> > On 04/04/18 15:11, Andrew Bartlett via samba-technical wrote:
> > > On Wed, 2018-04-04 at 11:43 +1200, Andrew Bartlett wrote:
> > > > This patch set prepares for the new LMDB backend for Samba's ldb layer
> > > > by adding a battery of tests for the new key-value layer and some
> > > > small
> > > > accommodations elsewhere in Samba (like not caching ldb handles across
> > > > a fork()).
> > > > 
> > > > It also removes a number of tdb-specific assumptions and tests the
> > > > GUID
> > > > index mode that is required in lmdb.
> > > > 
> > > > This addresses metze's request that the tests be included before the
> > > > lmdb patch set is merged.
> > > > 
> > > > Please review and push on top of my previous patch set.
> > > 
> > > This patch set contains less patches, but is easier for the LMDB branch
> > > to land on top of.
> > > 
> > > Please review/push on top of the other patches for the re-index issues.
> > > 
> > > Thanks!
> > > 
> > > Andrew Bartlett
> 
> Thanks Gary,
> 
> Here is an updated patch set with a few more patches brought in,
> including the mdb_copy.py we missed out when a larger patch was split
> apart in the submission last month.  I've successfully re-built the
> LMDB patch set on top of this.
> 
> The CI results will be here:
> 
> https://gitlab.com/catalyst-samba/samba/pipelines/19932509

Wow, this is great work and a load of unit tests.



-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org