[PATCH] Prepare for LMDB by improving ldb_tdb and Samba callers

Andrew Bartlett abartlet at samba.org
Wed Apr 4 00:22:02 UTC 2018

On Tue, 2018-04-03 at 20:04 -0400, jim via samba-technical wrote:
> The first tdb_transaction_active() should be 
> !tdb_transaction_active(ltdb->tdb) instead of ... == false. It is boolean.

Thanks for the feedback.  

I agree it should be consistent, but I find == false clearer. 

However in switching from a local variable check to a function, we
should be mindful of the README.Coding "Make use of helper variables"
rule.  I'll fix these up to match that rule.

Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list