[PATCH] Fix a few CIDs

Stefan Metzmacher metze at samba.org
Tue Apr 3 20:36:36 UTC 2018


Hi Volker,

> @@ -202,6 +203,7 @@ static uint32_t _reg_perfcount_multi_sz_from_tdb(TDB_CONTEXT *tdb,
>  	working_size = (dbuf.dsize + 1)*sizeof(uint16_t);
>  	buf1 = (char *)SMB_REALLOC(buf1, buffer_size + working_size);
>  	if(!buf1) {
> +		SAFE_FREE(buf1);
>  		buffer_size = 0;
>  		return buffer_size;
>  	}

Don't we need a helper variable here? SAFE_FREE(NULL) is not what we want:-)

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180403/a66999c0/signature.sig>


More information about the samba-technical mailing list