[PATCH] Enforce strict overflow checking

Jeremy Allison jra at samba.org
Tue Apr 3 15:45:25 UTC 2018

On Tue, Apr 03, 2018 at 02:02:53PM +0200, Andreas Schneider wrote:
> Ah, sorry my bad. I didn't have the tree with the reverted patch. Here we go:
> ../source3/nmbd/nmbd_incomingrequests.c: In function 
> ‘process_node_status_request’:
> ../source3/nmbd/nmbd_incomingrequests.c:344:8: error: assuming pointer 
> wraparound does not occur when comparing P +- C1 with P +- C2 [-Werror=strict-
> overflow]
>   while (buf < bufend) {
>         ^
> cc1: all warnings being treated as errors

Ah, I'm not seeing that. What version of gcc are you using ?

Are there a lot of these in nmbd ? Is it worth fixing nmbd
first, or set to ignore now and work on them later ?


More information about the samba-technical mailing list