[PATCH] notifyd: Broadcast to all connected nodes

[Volker Lendecke]

On Thu, Sep 28, 2017 at 03:10:22PM +1000, Amitay Isaacs via samba-technical wrote:
> Hi,
> 
> Replace CTDB_BROADCAST_VNNMAP with CTDB_BROADCAST_CONNECTED.
> 
> Please review and push.

Pushed, thanks!

Volker

> 
> Amitay.

> From 246adc573bb1aad4e03891b1fa77c4a833339eea Mon Sep 17 00:00:00 2001
> From: Amitay Isaacs <amitay at gmail.com>
> Date: Thu, 28 Sep 2017 11:44:50 +1000
> Subject: [PATCH] notifyd: Broadcast to all connected nodes
> 
> CTDB_BROADCAST_VNNMAP includes only the nodes with lmaster roles.
> CTDB_BROADCAST_CONNECTED includes all the running nodes.
> 
> Signed-off-by: Amitay Isaacs <amitay at gmail.com>
> ---
>  source3/smbd/notifyd/notifyd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/source3/smbd/notifyd/notifyd.c b/source3/smbd/notifyd/notifyd.c
> index f645781afea..e4e5c785472 100644
> --- a/source3/smbd/notifyd/notifyd.c
> +++ b/source3/smbd/notifyd/notifyd.c
> @@ -81,7 +81,7 @@ struct notifyd_state {
>  	 * broadcasts its messaging_reclog to every other notifyd in
>  	 * the cluster. This is done by making ctdb send a message to
>  	 * srvid CTDB_SRVID_SAMBA_NOTIFY_PROXY with destination node
> -	 * number CTDB_BROADCAST_VNNMAP. Everybody in the cluster who
> +	 * number CTDB_BROADCAST_CONNECTED. Everybody in the cluster who
>  	 * had called register_with_ctdbd this srvid will receive the
>  	 * broadcasts.
>  	 *
> @@ -999,7 +999,7 @@ static void notifyd_broadcast_reclog(struct ctdbd_connection *ctdbd_conn,
>  				  .iov_len = blob.length };
>  
>  	ret = ctdbd_messaging_send_iov(
> -		ctdbd_conn, CTDB_BROADCAST_VNNMAP,
> +		ctdbd_conn, CTDB_BROADCAST_CONNECTED,
>  		CTDB_SRVID_SAMBA_NOTIFY_PROXY, iov, ARRAY_SIZE(iov));
>  	TALLOC_FREE(blob.data);
>  	if (ret != 0) {
> -- 
> 2.13.5
> 


-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de