[PATCH] Next round of netlogon_cli_creds refactoring
Volker.Lendecke at SerNet.DE
Mon Sep 25 06:47:42 UTC 2017
On Mon, Sep 25, 2017 at 07:08:41PM +1300, Andrew Bartlett wrote:
> On Mon, 2017-09-25 at 06:04 +0200, Volker Lendecke wrote:
> > On Mon, Sep 25, 2017 at 01:33:15PM +1300, Andrew Bartlett wrote:
> > > The final patch looks wrong, was it brought in from a larger branch you
> > > were working on? A compiler with --picky-developer shows that with
> > > netlogon_creds_cli_lock() static, it is un-used.
> > No, this was deliberate. I want to get rid of the cli_lock function. I
> > just had not run a full autobuild with this, functionally making a
> > function static should not make any difference. Without that, it had
> > survived an autobuild. It's only the sync wrapper that is unused, the
> > async ones are still used but should not be used outside this
> > function.
> > > Otherwise it seems OK to me.
> > Is that a formal RB+?
> With that clarified:
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> for everything bar this last patch.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical