[PATCH] Next round of netlogon_cli_creds refactoring

Andrew Bartlett abartlet at samba.org
Mon Sep 25 00:33:15 UTC 2017

On Thu, 2017-09-21 at 00:02 +0200, Volker Lendecke via samba-technical
> On Sun, Sep 17, 2017 at 03:36:17PM +1200, Andrew Bartlett via samba-
> technical wrote:
> > I remember writing (part of) that comment you moved about
> > SamLogonEx,
> > and it is so nice to have an infrastructure like the
> > netlogon_cli_creds
> > that solves the problem properly.  It was really easy to plug in
> > for
> > more calls when we had to implement SendToSam recently. 
> Attached find the whole patchset. rpccli_connect_netlogon might be a
> bit subtle, but I think this properly covers connecting to netlogon
> in
> a scalable manner.
> Comments?

The final patch looks wrong, was it brought in from a larger branch you
were working on?  A compiler with --picky-developer shows that with
netlogon_creds_cli_lock() static, it is un-used.

Otherwise it seems OK to me.


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list