[PATCHES] Generate shorter name for extra python files
abartlet at samba.org
Fri Sep 22 22:15:17 UTC 2017
On Fri, 2017-09-22 at 22:49 +0200, Lukas Slebodnik wrote:
> But as i showed you in previous example it is not a problem that
> symbol is in version script because it is not part of util library
> for python3. Version script is used as a whitelist to allow symbols from
> objects *.o appear in library. But if symbol is missing in object files
> it will not be part of library even though it is in version script.
> Section 2.2 says:
> The concept of export maps is to tell the linker explicitly
> which symbols to export from the generated object.
> And it is much simpler to use version script(export maps)
> then __attribute__ ((visibility ("hidden")))
> But if you prefer to have separate version script(ABI/*) for python2
> and python3 I do not have a problem with that. I can just see a small
> benefit in de-duplication.
The ABI files are not just for the version scripts. They are also used
to determine if a symbol is removed or the signature changed, and
triggers logic to reject such a build.
If there is just one ABI file for both, then if python2 requires a
different ABI to python3, then either on the other will fail a build.
However, we don't want ABI files for each possible python3 version (35m
etc), just for python3 overall, hence the .py3 thing.
I hope this helps clarify things.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical